Template Parts: Return a stable reference for the defined 'area' #53675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
juanfra,
gziolo and
Addison-Stavlo
and removed request for
ajitbohra
|
Size Change: -11 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1435b5e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5866208062
|
Addison-Stavlo
approved these changes
Aug 15, 2023
|
Thanks for the review, @Addison-Stavlo 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discovered while working on #53666.
PR updates the
TemplatePartAdvancedControlscomponent and avoids returning new array references frommapSelect.Note: I've also moved
htmlElementMessagesdefinitions outside the component to avoid recreating a map object on each render.Why?
Array operations like
filterandmapwill return a new array on eachmapSelectcall. This can cause unnecessary rerenders.Testing Instructions
Screenshots or screencast