Editor: Fix the 'useSelect' warning in the 'useIsDirty' hook #53759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: +29 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
okmttdhr
approved these changes
Aug 18, 2023
jsnajdr
approved these changes
Aug 18, 2023
| for ( const property in siteEdits ) { | ||
| siteEditsAsEntities.push( { | ||
| editedSiteEntities.push( { | ||
| kind: 'root', | ||
| name: 'site', | ||
| title: TRANSLATED_SITE_PROPERTIES[ property ] || property, | ||
| property, | ||
| } ); |
There was a problem hiding this comment.
Here it's interesting that we're looking only at the keys of siteEdits, not the values. So, when I'm editing the site title or tagline, then, as i type, the siteEdits change, and trigger a recalculation and rerender. But the keys don't change, only the value.
Fixing this would be a micro-optimization of a very minor use case (editing site properties), probably not worth doing. But interesting to know about 🙂
There was a problem hiding this comment.
So should we just return the record keys for this one? Do we have a data selector to ensure the same value on every render?
P.S. I've another minor refactoring in mind for this hook - using reducer for the unselectedEntities state. Happy to include this micro-optimization there if you want to pursue it.
There was a problem hiding this comment.
Now I found that the __experimentalGetDirtyEntityRecords selector has exactly the same problem. But this one is much more widely used. Although its return value is still the same, and although it's memoized with createSelector, the value is recalculated on every keystroke, when changing any block. Because the memoization is invalidated on every content value change, but the content values are not used to calculate the return value.
It won't be easy to memoize this properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #50863.
PR fixes the following warning triggered by the
useIsDirtyhook:Why?
Array operations like
filterandmapwill return a new array on each mapSelect call. This can cause unnecessary rerenders. See #53666.How?
I moved the filtering logic outside into the
useMemohook. Similar to #53596.Testing Instructions
?theme_preview=[themePath], wherethemePathis the relative path to the theme you want to preview (e.g.,twentytwentythree).Screenshots or screencast
CleanShot.2023-08-17.at.14.45.40.mp4