Mobile - Inserter - Fix useSelect warnings for SearchResults and ReusableBlocksTab #53813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic from it to avoid unnecessary re-renders
geriux
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
…ering logic outside into a useMemo
geriux
changed the title
This was referenced Aug 18, 2023
|
Flaky tests detected in 46f89c3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5904004074
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #53738
Related PRs:
What?
After the #53666 merge, some warnings started to appear when opening/interacting with the inserter menu due to the usage of some
useSelect.Why?
To avoid showing these warnings while running the app in development mode and to improve the performance by preventing unnecessary re-renders.
How?
This PR addresses the warnings by extracting the filtering logic from
useSelectwithin theSearchResultsandReusableBlocksTabcomponents, to avoid returning new references and now they're stored in a variable wrapped in auseMemo.Testing Instructions
useSelectTesting Instructions for Keyboard
N/A
Screenshots or screencast
InserterWarningsBefore.mov
InserterWarningsAfter.mov