Patterns: Require a title in the creation modal #54717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
added
the
Backport to Gutenberg RC
|
Size Change: +6 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f79c1d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6271595138
|
This was referenced Sep 22, 2023
mikachan
pushed a commit
that referenced
this pull request
Sep 22, 2023
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 46697a3 |
mikachan
removed
the
Backport to Gutenberg RC
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #54693.
PR updates pattern creation logic in the modal and makes the title a requirement.
Why?
While WP allows post-type creation without titles, patterns are probably not very useful without them. This also matches the template part creation flow.
P.S. The post-editor template creation uses a fallback title, but I think this method is better.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast