Switcher: Only allow type conversions based on kinds #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Paragraphs, headings and quotes are _text_, hence they are convertible amongst that kind. - Images are only _images_ and, for now, offer no switching.
mcsf
added
[Type] Bug
mtias
approved these changes
Feb 10, 2017
hypest
pushed a commit
that referenced
this pull request
Nov 2, 2018
…-cursor-command Add a new `returnHTMLWithCursor` command & returning event to the editor
ntwb
added a commit
that referenced
this pull request
May 31, 2020
* Add stylelint 6.4.x rules * Bump minimum stylelint version to 6.4.2
ockham
added a commit
that referenced
this pull request
Dec 3, 2021
Unit tests are currently failing on `trunk` (when used with a current snapshot of the WordPress svn or git repo). Specifically: `Block_Fixture_Test::test_kses_doesnt_change_fixtures` fails for datasets #54 and #55. Reading WordPress/wordpress-develop#1998, I believe that the reason might be that our KSES routines are verifying that the specified port matches the one of the local install. And since our tests normally run `localhost:8889`, I'm updating the relevant test fixtures (from previously `8888`) to reflect that.
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
Unit tests are currently failing on `trunk` (when used with a current snapshot of the WordPress svn or git repo). Specifically: `Block_Fixture_Test::test_kses_doesnt_change_fixtures` fails for datasets #54 and #55. Reading WordPress/wordpress-develop#1998, I believe that the reason might be that our KSES routines are verifying that the specified port matches the one of the local install. And since our tests normally run `localhost:8889`, I'm updating the relevant test fixtures (from previously `8888`) to reflect that.
youknowriad
pushed a commit
that referenced
this pull request
Dec 8, 2021
Unit tests are currently failing on `trunk` (when used with a current snapshot of the WordPress svn or git repo). Specifically: `Block_Fixture_Test::test_kses_doesnt_change_fixtures` fails for datasets #54 and #55. Reading WordPress/wordpress-develop#1998, I believe that the reason might be that our KSES routines are verifying that the specified port matches the one of the local install. And since our tests normally run `localhost:8889`, I'm updating the relevant test fixtures (from previously `8888`) to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #43, the switcher menu was available for any type of block, notably images, which made no sense. This addresses that by paving the way for kind-based switcher controls. With this PR: