-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages list: set status
as no sortable
#55210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
An existing feature does not function as intended
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
labels
Oct 10, 2023
oandregal
changed the title
Set
Pages list: set Oct 10, 2023
status
as no sortablestatus
as no sortable
Set to 16.9 as the #55196 that introduced the bug is tagged for that release as well. |
Size Change: +3 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #55196
What?
Prevents the
status
column from being sortable.Why?
It was unintentionally made sortable at #55196 Apparently, when a tanstack column has a
accesorFn
it is made sortable.We cannot sort the pages table by this field because the REST API endpoint for pages doesn't allow us sorting by post status.
How?
Set it to non-sortable via
enableSorting
column definition.Testing Instructions
Test that the
status
column is not sortable.title
andauthor
are listed as fields to sort by in the view config: