Update ariakit to version 0.3.5 #55365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
commented
Oct 14, 2023
There was a problem hiding this comment.
@chad1008 I realised that the Tabs unit tests still assume that Tabs.Tab accepts an icon prop — I guess we should remove that from the prop types and from the unit tests (in a separate PR) ?
ciampo
added
[Type] Enhancement
|
Size Change: +317 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
35 tasks
brookewp
approved these changes
Oct 17, 2023
diegohaz
approved these changes
Oct 17, 2023
chad1008
approved these changes
Oct 18, 2023
ntsekouras
reviewed
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update
@ariakit/reactfrom version0.3.3to the (currently latest) version0.3.5Why?
To benefit from the latest additions and bug fixes (eg. several fixes to
Menuand its subcomponents)How?
Using npm.
From the release notes, there shouldn't be any breaking changes, although some changes in version
0.3.4caused a fewTabsunit tests to fail — likely related to the change "Controlled store updates are no longer flushed synchronously."I was able to fix the unit tests by:
useLayoutEffectinstead ofuseEffect(see this article explaining the differences)I also changed the
Tooltipcomponent to use the newly introducedunmountOnHide, instead of the previous custom logic.Testing Instructions
From the release notes, there shouldn't be any breaking changes, although some changes in version
0.3.4caused a fewTabsunit tests to fail — likely related to the change "Controlled store updates are no longer flushed synchronously."We should make sure that components using ariakit are still working as expected in Storybook and the editor:
TabPanelTabsToggleGroupControlToolbarTooltip