Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON schema: add heading/button key to color definition #55674

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Theme JSON schema: add heading/button key to color definition #55674

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ce1a78
Theme JSON schema: add heading/button key to color definition
t-hamano Oct 28, 2023
49c78a4
Update docs
t-hamano Oct 28, 2023
3fbc68f
Merge branch 'trunk' into schema/theme-button-heading
t-hamano Nov 22, 2023
2148f5a
Add "in a block"
t-hamano Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/reference-guides/theme-json-reference/theme-json-living.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ Settings related to colors.
| link | boolean | false | |
| palette | array | | color, name, slug |
| text | boolean | true | |
| heading | boolean | true | |
| button | boolean | true | |

---

Expand Down
10 changes: 10 additions & 0 deletions schemas/json/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,16 @@
"description": "Allow users to set text colors.",
"type": "boolean",
"default": true
},
"heading": {
"description": "Allow users to set heading colors.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this confusing because it can easily be mixed up with styles > elements > headings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. What about "Allow users to set heading colors in a block."?

"type": "boolean",
"default": true
},
"button": {
"description": "Allow users to set button colors.",
"type": "boolean",
"default": true
}
},
"additionalProperties": false
Expand Down
Loading