Migrate 'CPT locking' e2e tests to Playwright #55929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
talldan and
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: -2 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dd80a96. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6785073352
|
kevin940726
reviewed
Nov 13, 2023
kevin940726
approved these changes
Nov 13, 2023
| @@ -273,9 +273,15 @@ test.describe( 'Post-type locking', () => { | |||
| .fill( 'p1' ); | |||
|
|
|||
| await editor.clickBlockOptionsMenuItem( 'Delete' ); | |||
| await expect.poll( editor.getBlocks ).not.toMatchObject( [ | |||
| await expect.poll( editor.getBlocks ).toMatchObject( [ | |||
There was a problem hiding this comment.
Oh, okay I just now understand what you mean in the original code 😅. Probably what the intent is to check that the blocks doesn't contain the paragraph block? This works but we could also do the below if we want to emphasize the intent.
await expect.poll( editor.getBlocks ).not.toContainEqual(
expect.objectContaining( { name: 'core/paragraph' } )
);There was a problem hiding this comment.
The current code probably isn't that different from what snapshots were testing, so from a migration PoV it should be good.
But I think we can use this pattern in the future.
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Migrate 'CPT locking' e2e tests to Playwright * Remove old test file and snapshot * Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Closes #44341.
Closes #48276.
PR migrates
cpt-locking.test.jse2e tests to Playwright.Why?
See #38851.
Testing Instructions