Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3578 Fix z-index issue with admin bar quick links and content structure tooltip #5630

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

faishal
Copy link
Contributor

@faishal faishal commented Mar 15, 2018

Description

Fix z-index issue with admin bar quick links and content structure tooltip

How Has This Been Tested?

Local environment with multuple browsers.

Screenshots (jpeg or gifs if applicable):

2018-03-15 13_59_08

Types of changes

Bug fix #3578

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@jorgefilipecosta
Copy link
Member

Thank you for your contribution @faishal, from the code point of view changes here look good.
This also changes the design of the inserter and makes the inserter bellow wp-admin drop-down:
image.

I'm pinging @jasmussen and @karmatosed so they can make a design review to the PR.

@jorgefilipecosta jorgefilipecosta added the Needs Design Feedback Needs general design feedback. label Mar 16, 2018
@karmatosed
Copy link
Member

Looks great to me, thanks @faishal for doing this.

@karmatosed karmatosed merged commit d46f9fd into WordPress:master Mar 21, 2018
@faishal faishal deleted the fix/popover-zindex branch March 22, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word Counts and Table of Contents layout - usability issues
3 participants