Dataviews: Add: Bulk actions to templates. #56615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Feature] DataViews
|
Size Change: +174 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
added
Needs Design Feedback
|
For me this is the use case where designers should give feedback. For example if an item has no actions at all, I guess we shouldn't show the selection checkbox. The most important thing IMO is how to handle if an item has actions, but we select two items that have different actions(one revert and the other delete). |
afercia
reviewed
Nov 29, 2023
| decodeEntities( templates.length ) | ||
| ) | ||
| : sprintf( | ||
| /* translators: The template/part's name. */ |
There was a problem hiding this comment.
For consistency with following translators comments, I'd suggest to use the same format:
/* translators: %s: The template or template part's name. */
afercia
reviewed
Nov 29, 2023
| ) } | ||
| { templates.length > 1 | ||
| ? sprintf( | ||
| // translators: %s: The template or template part's title. |
There was a problem hiding this comment.
This comment should refer to the number of items: translators: The number of items.
afercia
reviewed
Nov 29, 2023
| templates.length > 1 | ||
| ? sprintf( | ||
| /* translators: The number of items. */ | ||
| __( '%s items reverted reverted.' ), |
jorgefilipecosta
force-pushed
the
add/bulk-actions
branch
from
f6f00b1 to
c43ebb6
Compare
|
Thanks for the ping, I'm very excited about this one!
It might be good to try showing the checkbox in the disabled state. On hover/focus is can show a tooltip explaining that there are no actions to apply to this record.
Good question. Would it be expensive to show a count on the buttons? Something like: 
That can help the user understand that the chosen action cannot be applied to the full selection. A couple of minor notes from initial testing:
|
oandregal
force-pushed
the
add/bulk-actions
branch
from
c43ebb6 to
43c3d85
Compare
Noting there's an ongoing discussion about the floating toolbar in the main 'bulk actions' PR, as it doesn't seem to be the most usable and accessible pattern. Aslo, quoting this comment from there:
|
jorgefilipecosta
force-pushed
the
add/bulk-actions
branch
from
6c28d98 to
8e0ab84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements bulk actions for templates.
The two bulk actions implemented are the revert template and the delete template.
Testing
Create two user templates verify it is possible to bulk delete them.
Apply user changes to some default templates, and verify it is possible to bulk revert them.
Screenshot