Command Palette: Use getRevisions instead of deprecated selector #56738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: +686 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Dec 3, 2023
Comment on lines
250
to
255
| const globalStylesRevisions = getRevisions( | ||
| 'root', | ||
| 'globalStyles', | ||
| __experimentalGetCurrentGlobalStylesId() | ||
| ); | ||
| return !! globalStylesRevisions?.length; |
There was a problem hiding this comment.
Thanks for picking this up @t-hamano 🙇🏻
Because the revisions response could be larger (at the moment up to 100 items in the collection), maybe it would be faster to grab the revision count from the version-history meta?
E.g.,
const globalStylesId = __experimentalGetCurrentGlobalStylesId();
const globalStyles = globalStylesId
? getEntityRecord( 'root', 'globalStyles', globalStylesId )
: undefined;
return globalStyles?._links?.[ 'version-history' ]?.[ 0 ]?.count || 0;
There was a problem hiding this comment.
+1, thanks for working on this!
That would be good if it's possible to use version-history and avoid the extra API call 👍
There was a problem hiding this comment.
Indeed. I updated it with 2257407 and confirmed that it continues to work as expected 👍
andrewserong
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #56349
What?
This PR refactors the deprecated
getCurrentThemeGlobalStylesRevisionsselector into thegetRevisionsselector in the Command Palette. This will prevent warning messages from appearing in the browser console.Why?
To improve code quality.
How?
Refactored it while keeping the logic. However, I added
!!to explicitly return abooleantype.Testing Instructions
Screenshots or screencast
2c76837f063b5b2ebb45e23b0abefe29.mp4