Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Remove wp-data-navigation-link directive #57853

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Interactivity API: Remove wp-data-navigation-link directive #57853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
444a148
Remove wp-data-navigation-link directive
cbravobernal Jan 15, 2024
8f5d1d2
Update changelog
cbravobernal Jan 15, 2024
2d287a3
Remove not needed functions
cbravobernal Jan 15, 2024
8012e31
Revert "Remove not needed functions"
cbravobernal Jan 15, 2024
0ed8337
Move breaking change changelog to correct position
cbravobernal Jan 15, 2024
d7e028e
Add function style to changelog
cbravobernal Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/interactivity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Breaking Change

- Remove `data-wp-slot` and `data-wp-fill`. ([#57854](https://github.com/WordPress/gutenberg/pull/57854))
- Remove `wp-data-navigation-link` directive. ([#57853](https://github.com/WordPress/gutenberg/pull/57853))

### Bug Fix

Expand Down
51 changes: 1 addition & 50 deletions packages/interactivity/src/directives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
/**
* External dependencies
*/
import {
useContext,
useMemo,
useEffect,
useRef,
useLayoutEffect,
} from 'preact/hooks';
import { useContext, useMemo, useRef, useLayoutEffect } from 'preact/hooks';
import { deepSignal, peek } from 'deepsignal';

/**
Expand All @@ -16,7 +10,6 @@ import { deepSignal, peek } from 'deepsignal';
import { createPortal } from './portals';
import { useWatch, useInit } from './utils';
import { directive } from './hooks';
import { navigate } from './router';

const isObject = ( item ) =>
item && typeof item === 'object' && ! Array.isArray( item );
Expand Down Expand Up @@ -264,48 +257,6 @@ export default () => {
);
} );

// data-wp-navigation-link
directive(
'navigation-link',
( {
directives: { 'navigation-link': navigationLink },
props: { href },
element,
} ) => {
const { value: link } = navigationLink.find(
( { suffix } ) => suffix === 'default'
);

useEffect( () => {
// Prefetch the page if it is in the directive options.
if ( link?.prefetch ) {
// prefetch( href );
}
} );

// Don't do anything if it's falsy.
if ( link !== false ) {
element.props.onclick = async ( event ) => {
event.preventDefault();

// Fetch the page (or return it from cache).
await navigate( href );

// Update the scroll, depending on the option. True by default.
if ( link?.scroll === 'smooth' ) {
window.scrollTo( {
top: 0,
left: 0,
behavior: 'smooth',
} );
} else if ( link?.scroll !== false ) {
window.scrollTo( 0, 0 );
}
};
}
}
);

// data-wp-ignore
directive(
'ignore',
Expand Down
Loading