Interactivity Router: Replace data-wp-navigation-id with data-wp-router-region
#58191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
DAreRodz
changed the base branch from
trunk
to
try/interactivity-api-router-module
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/blocks/render-query-test.php |
|
Size Change: -45 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
47 tasks
DAreRodz
requested review from
spacedmonkey,
gziolo,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Flaky tests detected in fe2c923. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7645920452
|
cbravobernal
requested changes
Jan 24, 2024
DAreRodz
force-pushed
the
try/interactivity-api-router-regions
branch
from
77fd926 to
fe2c923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tracking issue: #56803
Created on top of #57924
Replaces all the
data-wp-navigation-iddirectives withdata-wp-router-region.The PR also adds a minor refactor to the Query block's focus logic.
Why?
We changed the name to something more appropriate and related to the new
@wordpress/interactivity-routerpackage.Testing Instructions
Ensure the Query block works as expected with the "Force page reload" option disabled.