Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles revisions: fix is-selected rules from affecting other areas of the editor #58228

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Global styles revisions: fix is-selected rules from affecting other areas of the editor #58228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions packages/edit-site/src/components/global-styles/screen-revisions/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,25 @@
// This border serves as a background color in Windows High Contrast mode.
border: 4px solid transparent;
}

&.is-selected {
border-radius: $radius-block-ui;

// Only visible in Windows High Contrast mode.
outline: 3px solid transparent;
outline-offset: -2px;

color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #007cba));
background: rgba(var(--wp-admin-theme-color--rgb), 0.04);

.edit-site-global-styles-screen-revisions__revision-button {
opacity: 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case anyone else wonders while looking at this: the opacity: 1 rule is required so that the .components-button:disabled opacity of .3 isn't applied here.

}

.edit-site-global-styles-screen-revisions__date {
color: var(--wp-admin-theme-color);
}

&::before {
background: var(--wp-components-color-accent, var(--wp-admin-theme-color, #007cba));
}
Expand Down Expand Up @@ -81,17 +93,6 @@
}
}

.is-selected {
color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #007cba));
background: rgba(var(--wp-admin-theme-color--rgb), 0.04);
.edit-site-global-styles-screen-revisions__revision-button {
opacity: 1;
}
.edit-site-global-styles-screen-revisions__date {
color: var(--wp-admin-theme-color);
}
}

.edit-site-global-styles-screen-revisions__apply-button.is-primary,
.edit-site-global-styles-screen-revisions__applied-text {
align-self: flex-start;
Expand Down
Loading