Editor: Use hooks instead of HoCs in the post-taxonomies components #58446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Jan 30, 2024
Comment on lines
-116
to
-138
| rerender( | ||
| <PostTaxonomies | ||
| postType="book" | ||
| taxonomies={ [ | ||
| genresTaxonomy, | ||
| { | ||
| ...categoriesTaxonomy, | ||
| types: [ 'post', 'page', 'book' ], | ||
| }, | ||
| ] } | ||
| /> | ||
| ); | ||
|
|
||
| expect( screen.getByRole( 'group', { name: 'Genres' } ) ).toBeVisible(); | ||
| expect( | ||
| screen.getByRole( 'group', { name: 'Categories' } ) | ||
| ).toBeVisible(); | ||
| expect( | ||
| screen.getByRole( 'button', { name: 'Add new genre' } ) | ||
| ).toBeVisible(); | ||
| expect( | ||
| screen.getByRole( 'button', { name: 'Add new category' } ) | ||
| ).toBeVisible(); |
There was a problem hiding this comment.
I have removed these assertions as they weren't testing real scenarios. The taxonomy definitions are coming from the server, and they don't change after the initial render.
tyxla
approved these changes
Jan 30, 2024
| taxonomies: select( coreStore ).getTaxonomies( { per_page: -1 } ), | ||
| }; | ||
| }, [] ); | ||
| const visibleTaxonomies = ( taxonomies ?? [] ).filter( |
There was a problem hiding this comment.
Nice work combining the 2 filter() calls in a single one 👍
|
Thanks for the review, @tyxla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
PostTaxonomiesCheckandPostTaxonomiescomponents to use data hooks instead of HoCs.Why?
A micro-optimization makes the rendered component tree smaller.
This is similar to #53773.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Before
After
