CustomGradientPicker: Hard deprecate outer margins #58699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
added
Needs Dev Note
20 tasks
mirka
added
[Type] Code Quality
|
Size Change: -91 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
32 tasks
mirka
added
has dev note
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358
What?
Promotes
__nextHasNoMarginon CustomGradientPicker to the default behavior.Why?
The deprecation grace period has elapsed.
Testing Instructions
In the Storybook for CustomGradientPicker, turn on the margin checker tool in the toolbar. The margin-free styles should now be the default, and the
__nextHasNoMarginprop should not be listed in the props table.✅ CustomGradientPicker is not directly used in the Gutenberg app.
✅ All internal components that use CustomGradientPicker under the hood are already using it in margin-free mode.
✍️ Dev Note
A number of UI components currently ship with styles that give them top and/or bottom margins. This can make it hard to reuse them in arbitrary layouts, where you want different amounts of gap or margin between components. To better suit modern layout needs, we are in the process of deprecating these outer margins
A few releases ago, we deprecated the outer margins on a number of components and introduced transitional props so consumers could opt into these new styles before they become the default:
AnglePickerControl:__nextHasNoMarginBottomCustomGradientPicker:__nextHasNoMarginFontSizePicker:__nextHasNoMarginBottomGradientPicker:__nextHasNoMarginIn WordPress 6.5, these margin-free styles have become the default. Any use of these props can be safely removed.