List block: allow tab to indent/outdent at selection start #59199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
What should |
|
Flaky tests detected in 67b6b53. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7975127386
|
skorasaurus
added
the
[Focus] Accessibility (a11y)
|
Question. What if you want to bold an indented list item? How do we communicate to users that selecting a list item and pressing Shift+Tab will not land them in the toolbar? Tab is easier because there's really nothing useful there for specific text changes. I wonder if this is another example of where some type of helpful hint should be used. |
|
@alexstine What do you imagine? Something with |
|
@ellatrix Is there a simple way to add a dialog/modal tip?
Ultimately the main issue is, there is no easy way to implement common shortcuts as they are already used. :( |
|
CC: @joedolson @afercia |
Btw, Shift+Tab is only taken over for outdent/indent for a collapsed selection. So selecting some text, and pressing Shift+Tab to get to the bold button still works. |
|
Let's merge. Yes there's a very limited clash but only when there's a collapsed selection at the start of a list item. Most of the time you'll want to use the formatting buttons after selecting text, and you can still use the cmd+b shortcut if you really want to bold without selecting text. We can look into communicating the behaviour, but would love the help of a11y experts there to propose how. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Same as #56474, but adds tab to indent and shift+tab to outdent only when the selection is at the start of the list time, which means normal tab/shift+tab behaviour is preserved elsewhere in the list item.
Why?
See #45404.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast