[Editor]: Move Post Status to editor package #59877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
Needs Design Feedback
ntsekouras
requested review from
youknowriad,
jameskoster,
SaxonF and
jasmussen
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Mar 14, 2024
| @@ -135,23 +134,12 @@ export class PostPublishButton extends Component { | |||
| ( ! isPublishable && ! forceIsDirty ) ) && | |||
| ( ! hasNonPostEntityChanges || isSavingNonPostEntityChanges ); | |||
|
|
|||
| let publishStatus; | |||
There was a problem hiding this comment.
I might have been missing something here, but it seems we only did that because we hadn't all the available status options in post editor.. I'll cc @jorgefilipecosta as I saw he has made changes in the past..
|
Size Change: -263 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
unify/post-status-component
branch
from
3c0436e to
24287b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #52632
Part of: #59878
From the issue 59878:
Here maybe we could focus on what, if any, change we could make to the
statuspanel in site editor and depending on the progress of the discussions/designs, update the other editor later..In general this PR will stay on hold until we decide how to move forward.
Testing Instructions
statuspanel that works properly