Code Quality: Use contentOnly locking for pattern block #61227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Synced Patterns
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
changed the title
|
Size Change: -7 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
…eck in block inspector
talldan
force-pushed
the
try/content-only-pattern-block
branch
from
ee3f54f to
af4d7fe
Compare
|
Flaky tests detected in af4d7fe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8917915951
|
aaronrobertshaw
approved these changes
May 2, 2024
|
The flaky tests seem weird and might be related, but they have already happened on trunk 🤔. I think they are separate issues. |
Seems like it's this commit where it started happening most recently, though it doesn't necessarily mean that's the one that caused it: 59ed45e It might also be related to this issue - #61038. |
talldan
added a commit
that referenced
this pull request
May 10, 2024
…block check in block inspector (#61227)" (#61517) This reverts commit 1351c67. Co-authored-by: talldan <[email protected]> Co-authored-by: kevin940726 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Minor tidy-up. In trunk, the pattern block uses
templateLock: 'allto prevent insertion between its inner blocks. It could usetemplateLock: contentOnlyinstead to achieve the same thing.Furthermore, there's a hard-coded check in the block inspector that ensures the pattern block shows the contentOnly quick navigation in the block inspector. This is actually not needed if the pattern block is set to
templateLock: contentOnlyso can be removedWhy?
It allows deletion of one line of code while achieving the same thing.
Testing Instructions
Everything should be the same as in
trunk