Refactor InserterTabs to use children and remove re-memoizing #61295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +151 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
reviewed
May 2, 2024
| const blocksTab = useMemo( | ||
| () => ( | ||
| const blocksTab = useMemo( () => { | ||
| if ( selectedTab !== 'blocks' ) { |
There was a problem hiding this comment.
I think this will make the tabs less performant, because we'll need to re-run this code every time the selected tab changes. It would be better to execute the code once and have it cached until we need to change it for another reason.
|
I pushed a change that removes the |
|
Flaky tests detected in 4483d6a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8922376366
|
The inserter performance results are consistently lower with the Checking the performance results from our separate commits, the |
|
@scruffian - while the memos do run more often with the
|
|
I'm running the tests again locally between the two and mostly getting better results without the |
|
We also discovered that the media and patterns tab were both being re-memoised because |
scruffian
approved these changes
May 2, 2024
|
This branch: trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #61108, which impacted the Inserter Search performance
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast