Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme.json schema: remove duplicate key #61523

Merged
merged 1 commit into from
May 10, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented May 9, 2024

What?

Removes the duplicate settings.dimensions key from the theme.json schema.

image

Why?

This key appears to have been added in #47271, but I think that's not what we intended.

@t-hamano t-hamano self-assigned this May 9, 2024
@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label May 9, 2024
@t-hamano t-hamano marked this pull request as ready for review May 9, 2024 11:35
Copy link

github-actions bot commented May 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano changed the title theme.json schema:remove duplicate key theme.json schema: remove duplicate key May 9, 2024
@t-hamano t-hamano requested a review from jffng May 9, 2024 11:36
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@t-hamano
Copy link
Contributor Author

@Mamaduka Thanks for the review!

@t-hamano t-hamano merged commit 7d63219 into trunk May 10, 2024
68 checks passed
@t-hamano t-hamano deleted the schema/fix-duplicate-dimensions branch May 10, 2024 05:38
@github-actions github-actions bot added this to the Gutenberg 18.4 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants