Inspector: Display home / posts page badge #62071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
jameskoster
requested review from
youknowriad,
jorgefilipecosta,
ntsekouras and
a team
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +181 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
May 29, 2024
youknowriad
reviewed
May 29, 2024
| > | ||
| { title ? decodeEntities( title ) : __( 'No Title' ) } | ||
| { isFrontPage && ( | ||
| <span className="editor-post-card-panel__title-badge"> |
There was a problem hiding this comment.
Is this badge something that can become a generic UI components to move to the components package? We're using it in multiple places now.
There was a problem hiding this comment.
Yes, probably so. Also in use for anchor tags in list view and within data views.
There was a problem hiding this comment.
Yes please #61106
youknowriad
reviewed
May 29, 2024
| } ), | ||
| isSync: _isSync, | ||
| isFrontPage: siteSettings?.page_on_front === _id, | ||
| isPostsPage: siteSettings?.page_for_posts === _id, |
There was a problem hiding this comment.
In other places the "id" here was typecast into an integer to work. I don't know whether it's needed here. cc @ntsekouras
There was a problem hiding this comment.
There was definitely an issue with some endpoint or selector in the past that would return a string id, but couldn't pinpoint it now.. By debugging and looking at the code, at least in these checks, both values are numbers. So it's safe to leave as is.
youknowriad
approved these changes
May 29, 2024
Closed
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ntsekouras <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Display a badge in the Inspector when editing the front page or the posts page.
Why?
In data views this badge appears next to the title to help you identify these pages. However there's nothing in the Editor to communicate this detail.
Testing Instructions
As a follow-up it might be nice to update the icon too, but as that will involve touching the command palette/document title I'd prefer to explore it separately.