Rich text: preserve comments #62128
Merged
Rich text: preserve comments #62128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +224 B (+0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/rich-text-preserve-comments
branch
from
7fca390 to
98f3290
Compare
lysyjan
approved these changes
Nov 18, 2024
|
Flaky tests detected in 423d892. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11896127808
|
youknowriad
reviewed
Nov 22, 2024
| @@ -40,3 +36,18 @@ figcaption.block-editor-rich-text__editable [data-rich-text-placeholder]::before | |||
| background: rgb(255, 255, 0); | |||
| } | |||
| } | |||
|
|
|||
| [data-rich-text-comment], | |||
There was a problem hiding this comment.
What is this attribute about?
There was a problem hiding this comment.
It stores the data inside comments
There was a problem hiding this comment.
And also marks a placeholder as a comment
youknowriad
reviewed
Nov 22, 2024
youknowriad
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #60735.
Fixes #13318.
This PR preserves HTML comments in rich text. Currently they are stripped out when HTML is parsed by rich text.
Why?
We should leave the content intact and interfere as little as possible. While useful on its own (and fixing a bug), this is also a preparatory PR for Bits, as it will make use of comments to anchor dynamic content inline. In the editor, the comment will then be replaced through an API by either a placeholder or the data.
How?
Rich text uses the browser's HTML parser, so it's quite easy to store this internally.
Testing Instructions
Insert a comment in a paragraph (through the code/HTML editor) and switch back to visual. There should be a placeholder. Edit the paragraph, and the placeholder/comment should remain.
Testing Instructions for Keyboard
Screenshots or screencast