Block API: Indent serialized block output with tabs #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Block API
|
Nice. This also fixes a bug where the HTML block complains about indentation using spaces after the editor reloads.
|
noisysocks
approved these changes
Apr 18, 2018
aduth
force-pushed
the
update/js-beautify-indent-tab
branch
from
0ae4979 to
0cb9915
Compare
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4456
This pull request seeks to propose indenting the serialized block output with tabs, rather than four spaces. Aside from being the objectively superior mode of indentation, tabs are advantageous for reducing the storage requirements of post content. As an example, for the demo post, using tabs saves 93 bytes. This number would be higher for content with significant indentation, notably heavily nested content.
I encountered this as part of implementing a custom serialize beautifier for #4456 (comment) , extracted here since there's a large number of affected fixture files and test assertions. The change itself is merely a single option to
js-beautify:indent_with_tabs: true.The block validator is intended to be whitespace-agnostic (aside from "meaningful" HTML whitespace), so there is intended to be no invalidations incurred by this change.
Testing instructions:
Ensure unit tests pass:
Verify that saving a post and reloading the editor results in no invalid blocks.