Block Variations: Detect active variation correctly based on RichText attribute #62325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
Size Change: +15 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ockham
force-pushed
the
fix/get-active-block-variation-rich-text-comparison
branch
from
03f14d9 to
137323d
Compare
cbravobernal
approved these changes
Jun 5, 2024
gziolo
approved these changes
Jun 5, 2024
|
Thank you very much, folks! Going to merge, since failing performance tests seem to be unrelated. |
vcanales
pushed a commit
that referenced
this pull request
Jun 5, 2024
… attribute (#62325) If a block variation has an `isActive` property that is an array of strings (i.e. attribute names), and one of the attributes referenced therein is a `RichText` value, compare the given `RichText` string correctly to the given block's. (This applies also to nested attributes, i.e. if a `RichText` value is contained in an object (that might be contained in another, and so on) inside an attribute.) Co-authored-by: ockham <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]>
|
I just cherry-picked this PR to the release/18.5 branch to get it included in the next release: 5fcb3ee |
vcanales
removed
the
Backport to Gutenberg RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
… attribute (#62325) If a block variation has an `isActive` property that is an array of strings (i.e. attribute names), and one of the attributes referenced therein is a `RichText` value, compare the given `RichText` string correctly to the given block's. (This applies also to nested attributes, i.e. if a `RichText` value is contained in an object (that might be contained in another, and so on) inside an attribute.) Co-authored-by: ockham <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
… attribute (#62325) If a block variation has an `isActive` property that is an array of strings (i.e. attribute names), and one of the attributes referenced therein is a `RichText` value, compare the given `RichText` string correctly to the given block's. (This applies also to nested attributes, i.e. if a `RichText` value is contained in an object (that might be contained in another, and so on) inside an attribute.) Co-authored-by: ockham <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]>
6 tasks
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
… attribute (WordPress#62325) If a block variation has an `isActive` property that is an array of strings (i.e. attribute names), and one of the attributes referenced therein is a `RichText` value, compare the given `RichText` string correctly to the given block's. (This applies also to nested attributes, i.e. if a `RichText` value is contained in an object (that might be contained in another, and so on) inside an attribute.) Co-authored-by: ockham <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If a block variation has an
isActiveproperty that is an array of strings (attribute names), and one of the attributes referenced therein is aRichTextvalue, compare the givenRichTextstring correctly to the given block's.Why?
Block variations aren't currently recognized as active if one of the distinguishing attributes is a RichText value, see #62031 (comment).
How?
By translating the
RichTextDataobject received from the given block's attributes to an HTML string, viaRichTextData.toHTMLString().Testing Instructions
Apply the following patch to create a variation of the Paragraph block:
Then, create a new post and insert a Paragraph block in the editor that matches the variation -- e.g. by switching to the Code Editor and pasting the following markup:
In the Block Inspector, verify that the variation is correctly recognized as "Warning with color" (rather than "Paragraph").
Note that if you make any modification to that block (e.g. change the text or formatting), it will no longer be recognized, and will show up as "Paragraph" block in the Block Inspector insted.
Screenshots or screencast