Add Button support for iconPosition top and showDescription #62412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +106 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Note: while working on this PR I noticed a with icon buttons and the buttons flex layout. By default the SVG icons are flex items and they can shrink. Normally, this isn't a problem. But, when a button shows both the icon and the text and the button width is constrained in some way, the icon shrinks and gets smaller. The width constrained may come, for example, from a container element or from some width set to a custom button. I don't think icons should ever shrink so I added
|
afercia
force-pushed
the
add/button-position-top-show-description
branch
from
63b3a06 to
9d200ae
Compare
|
Flaky tests detected in 7292658. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9580890599
|
afercia
force-pushed
the
add/button-position-top-show-description
branch
from
7292658 to
a65690f
Compare
afercia
force-pushed
the
add/button-position-top-show-description
branch
from
a65690f to
f5c569f
Compare
|
I second @mirka 's feedback shared here. it seems that looking for a more generic and modular solution like in #62373 (comment) could be a better way forward. More in general, I don't think I'll let Lena answer directly next week, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62373
What?
iconPositionprop to support a newtopvalue.showDescriptionprop to make the Button accessible description visible.Why?
As detailed in #62373 there are scenarios where a Button would benefit from a couple new features:
Both features would allow to avoid 'ad-hoc' implementations and overrides in the editor components, which also add maintenance cost, inconsistencies, and are prone to bugs and reduced accessibility.
How?
See above
Testing Instructions
npm run storybook:dev.iconPositionprop to 'top.describedByprop.showDescriptionprop totrue.Testing Instructions for Keyboard
Screenshots or screencast