Improve maintainability of theme json class tests.

[tellthemachines]

What?

Partially addresses #60842.

This PR syncs WordPress/wordpress-develop#6734 to Gutenberg. I also adjusted a couple tests that don't exist in core yet to not output base layout styles.

Testing Instructions

1. Run the PHP tests and check that everything passes.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/bootstrap.php
❔ phpunit/class-wp-theme-json-test.php

[tellthemachines]

If I'm reading the comments above this test and the next one correctly, we should be able to update them to use core blocks now?

[aaronrobertshaw]

That's my understanding. We should be able to update these tests to core blocks and remove the filter registering the test block from the phpunit bootstrap.

I can look a little deeper on this tomorrow if that helps?

[tellthemachines]

Thanks for confirming, I'll give it a go and see if it works!

[tellthemachines]

Does the "deprecated" in the test name refer to defining selectors with __experimentalSelector inside the supports array (like Calendar or Button do) as opposed to outside (like Image does)?

[andrewserong]

I believe so, it looks like this test was renamed from test_get_stylesheet_with_block_support_feature_level_selectors in #46496 which stabilised that feature and moved it outside of supports.

[aaronrobertshaw]

The selectors API feature got merged by a good samaritan before it was actually ready so following threads like #46486 will be tricky as the individual PRs only contain part of the "story".

To answer the question, yes, the deprecated __experimentalSelector properties are what the test was about as we have to maintain backwards compatibility for them unfortunately.

[tellthemachines]

Thanks folks, all done! I trimmed the properties output to match what each block supports, and that also makes the strings a more manageable size.

[github-actions]

Flaky tests detected in 0077769.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9475662692
📝 Reported issues:

• [Flaky Test] submenu click on the arrow interactions #61884 in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js

[andrewserong]

Looking good — very cool that real core blocks could be used for both cases of the deprecated and proper selectors, too, that helps simplify things a fair bit.

Just left a couple of tiny nit comments in the strings that are output on test failures, but other than that this LGTM! 🚀