Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse block: add background image and minimum height support #62498

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Verse block: add background image and minimum height support #62498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ Insert poetry. Use special spacing formats. Or quote song lyrics. ([Source](http

- **Name:** core/verse
- **Category:** text
- **Supports:** anchor, color (background, gradients, link, text), interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight)
- **Supports:** anchor, background (backgroundImage, backgroundSize), color (background, gradients, link, text), dimensions (minHeight), interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight)
- **Attributes:** content, textAlign

## Video
Expand Down
13 changes: 13 additions & 0 deletions packages/block-library/src/verse/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@
},
"supports": {
"anchor": true,
"background": {
"backgroundImage": true,
"backgroundSize": true,
"__experimentalDefaultControls": {
"backgroundImage": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we collapse the background image tools panel by default?

I'm tending towards "yes" to avoid clutter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this. It's pretty compact

Screenshot 2024-06-12 at 3 15 09 PM

}
},
"color": {
"gradients": true,
"link": true,
Expand All @@ -29,6 +36,12 @@
"text": true
}
},
"dimensions": {
"minHeight": true,
"__experimentalDefaultControls": {
"minHeight": false
}
},
"typography": {
"fontSize": true,
"__experimentalFontFamily": true,
Expand Down
Loading