-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR template: add before/after table #62739
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go ahead with this PR, I feel a comment description may be necessary. One example is as follows. What do you think?
## Screenshots or screencast
<!-- If you would like to upload screenshots, please paste them in the table cells below, showing before and after this PR was applied. -->
|Before|After|
|-|-|
|||
Or:
|
Personally, I think it would be easier to understand if there were both comments suggested by you and mine. |
be16cdb
to
55d0772
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this PR according to this comment, and as I believe this PR still makes sense, I would like to approve it.
Flaky tests detected in 9826fb8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12095626471
|
9826fb8
to
9a8f6c6
Compare
Thanks @t-hamano, I've added a comment, also indicating that it's merely a suggestion and not a requirement when adding screenshots. |
Co-authored-by: ellatrix <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ellatrix <[email protected]> Co-authored-by: t-hamano <[email protected]>
What?
Adds a Before/After table to the PR template in the screenshot section.
Why?
How?
Adds a Markdown table skeleton.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast