Editor: Fix duplicate save panels #62863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
youknowriad,
scruffian,
jameskoster,
ellatrix and
t-hamano
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -75 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jun 26, 2024
|
@ntsekouras, follow-ing e2e test is still failing: |
ntsekouras
force-pushed
the
fix/duplicate-save-panels
branch
from
12c7d8c to
f6c6e70
Compare
Yeah, I updated it. |
youknowriad
reviewed
Jun 27, 2024
youknowriad
reviewed
Jun 27, 2024
ntsekouras
force-pushed
the
fix/duplicate-save-panels
branch
from
f6c6e70 to
6f28519
Compare
|
I had a chat with @youknowriad in private about some of the challenges this PR and the approach here, regarding his previous two comments. We agreed to preserve the |
youknowriad
reviewed
Jul 2, 2024
| /> | ||
| ) : undefined | ||
| ! isPreviewMode | ||
| ? customSavePanel || ( |
There was a problem hiding this comment.
I'm guessing these two conditions can be merged using a &&
There was a problem hiding this comment.
They could, but it would be like !x && a || b and because of the || I think it's a bit clearer this way..
youknowriad
reviewed
Jul 2, 2024
| @@ -41,7 +41,7 @@ test.describe( 'Site Editor - Multi-entity save flow', () => { | |||
| ).toBeEnabled(); | |||
| await expect( | |||
| page | |||
| .getByRole( 'region', { name: 'Save panel' } ) | |||
| .getByRole( 'region', { name: 'Editor publish' } ) | |||
There was a problem hiding this comment.
Why is this change needed? The region is for saving not just publishing no?
There was a problem hiding this comment.
Yeah, but that's what we call it for a while.. Should we change it in a follow up?
youknowriad
approved these changes
Jul 2, 2024
|
There was a conflict while trying to cherry-pick the commit to the wp/6.6 branch. Please resolve the conflict manually and create a PR to the wp/6.6 branch. PRs to wp/6.6 are similar to PRs to trunk, but you should base your PR on the wp/6.6 branch instead of trunk. |
ntsekouras
added a commit
that referenced
this pull request
Jul 2, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: t-hamano <[email protected]>
ellatrix
added a commit
that referenced
this pull request
Jul 2, 2024
* Editor: Fix duplicate save panels (#62863) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: t-hamano <[email protected]> * pass customSavePanel --------- Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: ellatrix <[email protected]>
ellatrix
added
Backported to WP Core
andrewserong
added
[Feature] Saving
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #62694
Related: #62813
Also fixes: #62702
This PR does a couple of things:
save panelsand you couldtabthrough both of them. Here I render only one and for now I followed the same approach we take for thecustomSaveButton. We pass the custom save panel only when we are previewing a theme and always render the site editor's save panel in sidebar and not in its layout component. This eventually should be handled in theeditorpackage probably without needing to pass these extra custom save button and panel.Screen.Recording.2024-06-26.at.10.34.14.AM.mov
open publish paneland here I changed it toopen save panelwhich makes more sense in most cases, since an entity couldn't bepublishableat all. This fixes this comment too.Screen.Recording.2024-06-26.at.10.37.59.AM.mov
open save panelbutton.Testing Instructions
viewmode in site editor we shouldn't be able to navigate to a save panel using tab.open save paneland is disabled when needs to.save buttonin the left sidebar should work exactly as before and render the save changes modal and save properly