Section Styles: Prevent flash of variation styles in post editor #63071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +4.46 kB (+0.25%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jul 3, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This will make the id retrieval a little more robust in case query string params are added to the URL in future etc.
talldan
approved these changes
Jul 3, 2024
ellatrix
reviewed
Jul 3, 2024
ellatrix
reviewed
Jul 3, 2024
|
This testing extremely well for me, and with some pretty hefty exploration of Section Styles. (Meaning my testing goes beyond just the Outline button.) LGTM for sure, with the hope it can get into RC3!!! |
|
It looks like the switch to |
This reverts commit 3f0f7b5.
|
After a brief look into the e2e failures, I'm not sure we can assume a standard URL to leverage Given the suggestion was noted as a "nit", I've reverted it for now in the interests of ensuring this fix lands for the next 6.6 RC. |
|
There is a backport for the PHP changes here available in WordPress/wordpress-develop#6959 |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.6 branch. Please resolve the conflict manually and create a PR to the wp/6.6 branch. PRs to wp/6.6 are similar to PRs to trunk, but you should base your PR on the wp/6.6 branch instead of trunk. |
aaronrobertshaw
added a commit
that referenced
this pull request
Jul 4, 2024
) Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: bgardner <[email protected]> Co-authored-by: justintadlock <[email protected]>
|
Cherry-pick and merge to the wp/6.6 branch here: |
aaronrobertshaw
added a commit
that referenced
this pull request
Jul 5, 2024
) (#63111) Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]>
ellatrix
added
Backported to WP Core
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…dPress#63071) Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: bgardner <[email protected]> Co-authored-by: justintadlock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62668
What?
Preloads theme and global styles data from REST API to avoid flash of variation styles in the post editor.
Why?
The flash of styling looks pretty rough and negatively impacts the experience of using the post editor when there are block style variations applied to blocks in the post.
How?
block_editor_rest_api_preload_pathsfilter to preload everything required for global styles data in the block editorurloption.Testing Instructions
Screenshots or screencast
Screen.Recording.2024-07-03.at.1.17.15.PM.mp4
Screen.Recording.2024-07-03.at.1.16.48.PM.mp4