Fix mobile styles for inserter pattern and media tab navigation #63451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@WordPress/gutenberg-design - This isn't perfect, but definitely better than before. I'm not sure if there were solid designs for how the mobile view of the pattern and media tabs is supposed to look |
|
Size Change: +5 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Jul 12, 2024
scruffian
pushed a commit
that referenced
this pull request
Jul 15, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
priethor
added
the
[Feature] Inserter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There was a regression in mobile styles for the pattern and media tabs.
Why?
How?
CSS changes -- trying to match what was previously there. I don't think it's perfect, but it's much more usable now. I think the back button should also be sticky, but that could be done in a follow-up.
Testing Instructions
On both mobile and desktop:
Check for visual style issues.
Testing Instructions for Keyboard
Screenshots or screencast
Before
Screen.Recording.2024-07-11.at.12.09.37.PM.mov
After
Screen.Recording.2024-07-11.at.12.09.08.PM.mov