Add post status icon in post summary #63658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Jul 17, 2024
| @@ -200,13 +207,15 @@ export default function PostStatus() { | |||
| variant="tertiary" | |||
| size="compact" | |||
| onClick={ onToggle } | |||
| icon={ postStatusesInfo[ status ]?.icon } | |||
| iconSize="20" | |||
There was a problem hiding this comment.
Without the iconSize, the row get a bit bigger than the 32px, which is like a min-height for rows. Any better alternatives are welcome.
There was a problem hiding this comment.
It's because .editor-post-panel__row-control .components-button was overriding the height value. Removing that fixed it, but revealed that the 'Parent' button was not the correct size, so I fixed that too.
|
Size Change: +311 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0f881de. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9974019925
|
jameskoster
approved these changes
Jul 18, 2024
ntsekouras
force-pushed
the
add/post-status-icon
branch
from
50bafc4 to
ffcbc48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of the discussion in this issue to make the post status in post summary a bit more prominent.
This PR adds an
iconnext to the post status.Testing Instructions
Screenshots or screencast