-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out: Add a control to enter and leave zoom out mode #63870
Changes from 17 commits
44744e8
c6cf55d
eef84ec
5610079
8bf3d40
d823a18
19e7361
5bd57eb
2dac622
a66ea9e
c0dee09
bca1413
2c7aa04
b8663bf
49ec7d1
69a1fb7
26f1dba
bfc4bcc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -242,10 +242,8 @@ function Iframe( { | |
const isZoomedOut = scale !== 1; | ||
|
||
useEffect( () => { | ||
if ( ! isZoomedOut ) { | ||
prevContainerWidth.current = containerWidth; | ||
Comment on lines
-245
to
-246
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder what led to this change? As I understand it the value of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch, I made a PR for that here: #64478 |
||
} | ||
}, [ containerWidth, isZoomedOut ] ); | ||
prevContainerWidth.current = containerWidth; | ||
}, [ containerWidth ] ); | ||
|
||
const disabledRef = useDisabled( { isDisabled: ! readonly } ); | ||
const bodyRef = useMergeRefs( [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the
<ZoomOutModeInserters />
from behind the experimentalwindow.__experimentalEnableZoomedOutPatternsTab
flag, as you can manually enter zoom out mode via this preview dropdown. I think this is the right call here. Otherwise you don't see the zoom out mode inserters unless you have the experiment on.