-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out: Add a control to enter and leave zoom out mode #63870
+101
−48
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
44744e8
Zoom Out: Add a control to enter and leave zoom out mode
scruffian c6cf55d
save the editing mode in a ref so we can restore it
scruffian eef84ec
update logic
scruffian 5610079
Update packages/editor/src/components/preview-dropdown/index.js
scruffian 8bf3d40
fix preview selection
scruffian d823a18
remove the experiment
scruffian 19e7361
remove disconnected change
scruffian 5bd57eb
make the code more readable
scruffian 2dac622
simplify code
scruffian a66ea9e
remove changes from the rebase
scruffian c0dee09
Render a down chevron in the dropdown
scruffian bca1413
don't run the use effect when the mode changes
scruffian 2c7aa04
Remove incorrect comment
scruffian b8663bf
Customized spacing for chevron in preview dropdown
jeryj 49ec7d1
minor tweaks
richtabor 69a1fb7
Simplify logic for preview selection and keep in line with editorMode
jeryj 26f1dba
Allow zoom out inserters if manually select zoom out mode from dropdown
jeryj bfc4bcc
Use desktop icon with 50% for zoom out
jeryj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what led to this change? As I understand it the value of
prevContainerWidth
should be that ofcontainerWidth
before Zoom Out is engaged because the scale calculation needs to arrive at a scale which preserves the document width. That calculation wasn’t perfect before but this seems to have thrown it off a good deal when Zoom Out is engaged by way of the Inserter (not through the control added by this PR).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I made a PR for that here: #64478