Add eslint rule for unlabeled RangeControl #63874
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Focus] Accessibility (a11y)
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Waiting on #63908 to merge
Part of #51740
What?
Adds an eslint rule for
RangeControlusage without alabelprop.Why?
This is a quick way to prevent unintentionally unlabeled controls in the Gutenberg app. Unfortunately there are quite a few that get past code review.
Additional components to be added to this lint list should be assessed on a case-by-case basis, but in general I don't foresee too many false positives (e.g. proper usage of a separate
<label>element).Testing Instructions
npm run lint:js -- --quietshould surface violations in RangeControl instances.🚧 Current violations must be fixed before merging