Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Warning and add notice for Navigation #63921

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Remove Warning and add notice for Navigation #63921

merged 4 commits into from
Sep 11, 2024

Conversation

AKSHAT2802
Copy link
Contributor

Fixes #59785

Screenshot 2024-07-25 at 1 05 25 PM Screenshot 2024-07-25 at 1 05 53 PM

@AKSHAT2802 AKSHAT2802 requested a review from ajitbohra as a code owner July 25, 2024 07:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: AKSHAT2802 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AKSHAT2802! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 25, 2024
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jul 25, 2024
@up1512001 up1512001 added the [Feature] Navigation Menus Any issue relating to Navigation Menus label Sep 8, 2024
@Mamaduka Mamaduka requested a review from afercia September 9, 2024 13:08
afercia
afercia requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AKSHAT2802 thanks for working on this and sorry for the late review. In the issue #59785 I proposed to change only the Warning in the Inspector panel, while this PR changes also the one in the editor canvas. Screenshot:

Screenshot 2024-09-10 at 08 38 38

Also, I'd agree with @Mamaduka that the Notice should not be dismissible.

Could you please have a look and address both points, when you have a chance?

@AKSHAT2802
Copy link
Contributor Author

AKSHAT2802 commented Sep 10, 2024 •
edited
Loading

Hey @afercia, Addressed both points and updated my PR.
As both the editor and inspector panel deleted navigation warning renders one file, I added a prop named isNotice and passed it true while triggering for the inspector panel.

This will only change the warning to a non-dismissable notice for the inspector panel.
I have verified that the deleted navigation warning only appears in 2 files one in the editor and the second in inspector control.
PFA: Screenshot attached
Screenshot 2024-09-11 at 1 35 25 AM

afercia
afercia requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AKSHAT2802 thanks for the update and the screenshot. Looks good to me, I'd only reduce doce duplication. See inline comment.

@AKSHAT2802
Copy link
Contributor Author

Thanks for the review @afercia & @Mamaduka
I have added a commit to reduce duplication.

@AKSHAT2802 AKSHAT2802 requested a review from afercia September 11, 2024 09:44
afercia
afercia approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AKSHAT2802 thank you. LGTM to me. Can be merged when all tests pass.

@Mamaduka Mamaduka merged commit b276647 into WordPress:trunk Sep 11, 2024
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.3 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afercia afercia afercia approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

Assignees

@AKSHAT2802 AKSHAT2802

Labels
[Feature] Navigation Menus Any issue relating to Navigation Menus First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 19.3
Development

Successfully merging this pull request may close these issues.

Replace DeletedNavigationWarning in the inspector with a Notice
4 participants
@AKSHAT2802 @Mamaduka @afercia @up1512001