Try: 1.5px styles icon circle. #64187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +22 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
In context the icon does feel a bit heavier than its contemporaries now. It's due partly to our familiarity with the current icon like you say, but I think it's also due to the filled section which is a relatively uncommon treatment; most icons (including those the styles icon commonly appears close to) are fully 'outlined': 
It's interesting to note that the effect seems to be more prominent in dark-on-light environments. To my eye the 'heaviness' is much less noticeable here: 
Overall I prefer to avoid random exceptions to the established conventions. It makes the current icon look uncanny, as if it snuck in from a different set. For that reason I'd update the stroke to 1.5. If we feel it's appearance is too heavy, then I'd explore a different treatment for the filled section, e.g.: 
|
|
The stripes are fun, though I think that changes the character in a different way. Overall I sense agreement that it may make sense to move this to 1.5px as a start? |
|
Should we land this one? Maybe no-one will notice! |
|
I think so; it aligns the icon with the set's conventions which is a step in right direction imo. If there's a feeling that the icon subsequently feels too heavy, that can be solved in other ways. |
|
Yep. ✅? |
jameskoster
approved these changes
Aug 6, 2024
|
Let's try this. As noted in the conversation, I'll be here for followups! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Draft. This one is not as obvious as it seems.
What I noticed was that the Styles icon uses a 1px stroke-width for the outer circle:
This is a divergence from the standard 1.5px stroke-width we apply in general to outline icons:
And yet, there's something about this icon that isn't necessarily obviously improved by making this stroke-width the same 1.5px size as others:
This is mostly visible in context. Before:
After:
Why?
I tend to think that this one feels awkward to me primarily because we've been looking at the old icon so much at this point. That objectively the correct stroke width of 1.5px is a better fit in context of the icons next to it (I can't unsee the differential now), but that subjectively, the icon loses a little bit of character with the thicker stroke-width.
What do you think?
Personal take: we should do it. It seems likely to eventually be a non-issue, since I expect the global styles sidebar to evolve and shift in how it's invoked, and that the consistency across is probably worth it. But it's not a strong opinion.
Testing Instructions
Go to the site editor, observe the global styles icon.