Move bulk actions menu to the Footer, consolidate with floating toolbar and total items display #64268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This seems to be working, but I'm getting some errors when building this PR, resulting in a broken appearance: 
Yup I think that's a reasonable place to start. |
jorgefilipecosta
force-pushed
the
update/new-bulk-actions-ui
branch
from
e72a20a to
f50c7a6
Compare
|
Size Change: -958 B (-0.05%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Hi @jameskoster,
I added the missing icons so all the actions could be executed with this new UI. |
|
I pushed a couple of style / layout adjustments. There seems to be a z-index issue on the templates / patterns pages. The bulk-select checkbox appears above the dataviews footer: 
Additionally you can 'click through' the footer to select the item beneath, leading to some strange behavior: bug.mp4 |
|
One other small request: Is it possible for the label to say "X items" when nothing is selected, then "X items selected" when a selection has been made? I think this will help distinguish between the total and the selection. |
jorgefilipecosta
force-pushed
the
update/new-bulk-actions-ui
branch
from
6b10de1 to
28fcb77
Compare
|
Hi @jameskoster, this PR passed by a big rebase, and all your feedback was addressed. Let me know if things are ok, I have some urgency in merging this PR as it is a big one that always has conflicts with other code changes and constantly needs rebases. |
|
Understood. I pushed a small styling regression fix. Other than that I see only one bug; sometimes the action buttons seem to get stuck in a busy state. It's easiest to replicate when restoring from trash: stuck.mp4It would be good to get more feedback from @WordPress/gutenberg-design, but otherwise this seems ready for a code review. |
|
Flaky tests detected in fc59412. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10451426325
|
t-hamano
reviewed
Aug 15, 2024
There was a problem hiding this comment.
I tested this PR and would like to share some of the things I noticed.
On the Templates page, if the pattern preview is behind footer buttons or checkboxes, I cannot click on the checkboxes or buttons, probably because the template card layer is placed on top.
I think we need to add a new z-index like z-index(".edit-site-patterns__dataviews-footer"). Instead, I think we can delete z-index(".edit-site-patterns__dataviews-list-pagination").
6be7964bc537bb18522c81dfb69f8199.mp4
When exported as JSON the buttons remain in a busy state. Furthermore, I cannot click on the Select/Deselect checkbox. This might be related to the revision button issue already mentioned in this comment.
a1318518ad8e33088b399033c9b0b74d.mp4
jorgefilipecosta
force-pushed
the
update/new-bulk-actions-ui
branch
from
72ec0b1 to
01c2c65
Compare
|
Hi @jameskoster, @t-hamano thank you for the reviews, the issues you reported are fixed. |
t-hamano
reviewed
Aug 17, 2024
There was a problem hiding this comment.
I have only one suggestion left, but everything seems to work fine.
The last thing I noticed is that the footer layout is broken on mobile screens:
I think the mobile screen layout is not yet complete overall, but it might be better to address this layout breakdown.
For example, by applying flex-wrap: wrap:
@jameskoster What do you think?
packages/dataviews/src/components/dataviews-pagination/index.tsx
Outdated
Show resolved
Hide resolved
|
I pushed some changes to switch to a columnar layout when the container reaches a certain size: 
This also fixes a regression with the pagination controls in List layout. What do you think? @jorgefilipecosta I noticed when the viewport width is between 600px and 780px the footer is entirely inaccessible. I couldn't figure out why though, perhaps you could take a look? |
jorgefilipecosta
force-pushed
the
update/new-bulk-actions-ui
branch
from
fc59412 to
4e6ebde
Compare
Hi @t-hamano, after the rebase and some style changes I think we are getting an aceptable behavior on mobile: 
|
|
@jameskoster thank you a lot for the fixes you included, they look good.
This was an already existing issue for pagination I submitted a fix at #64844. Let me know if you think this PR is ready to merge. I want to merge it soon because it is a big one needing constant rebases. |
t-hamano
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
LGTM!
Regarding the pagination issue, I know it's been fixed in this PR.
However, I think there is a more ideal approach, and we should be able to address it in #64844. Please see this comment.
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…ar and total items display (WordPress#64268) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: t-hamano <[email protected]>
bph
added
the
[Feature] DataViews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63193
Follows what was proposed at #63193, and moves the bulk actions currently available in the bulk actions menu and in the toolbar to a single location in the footer at the side of pagination.
In progress: Currently bulk actions that are not primary like export as json in patterns or the permanent delete are not able to be executed. We need to decide on what to do. Could we add icons to them and render them as the primary ones? cc: @jameskoster
Screenshots
Testing Instructions
Verified the bulk actions appeared on the footer and I could execute them with success.