-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Use hooks instead of HoC in 'BlockModeToggle' #64460
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -22 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
What?
PR updates the
BlockModeToggle
component to use data hooks instead of HoCs.I've also removed the
small
prop; it hasn't been used, and the component should always render a label for a11y.Why?
A micro-optimization makes the rendered component tree smaller.
Similar to #60807.
Testing Instructions
The feature also has e2e test coverage.
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-08-13.at.07.48.06.mp4