Media & Text: fix content loss from transform + add text transform #64540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Block Transforms
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +66 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
It might be better to have a single well-labeled transform, I'm not sure. But currently this is not possible.
That does seem like it would be ideal. Further, I think most any container block should feature the equivalent of the Group block’s "Ungroup" (maybe "Unwrap"). The exception I can think of would be Column as it can’t dump its inner blocks directly into the parent Columns.
In the mean time it makes sense to do this so content isn’t lost.
ellatrix
force-pushed
the
fix/media-text-transforms
branch
from
67b563a to
2e594b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #63635.
Currently the image and video transforms dump all the text you have next to the media.
The image, video and the newly introduced paragraph transform are all the same transform. They just transform the block into the base blocks.
It might be better to have a single well-labeled transform, I'm not sure. But currently this is not possible. The quote block is actually a bit similar: the "paragraph" transform actually converts it to the inner blocks, so it's also mislabelled.
Why?
You shouldn't lose your content.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast