Add 40px size lint rule for Block Editor typography components #64591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
ciampo
reviewed
Aug 17, 2024
Tweaked the rule to exclude all test and story files (1c541c7). In my experience up to this point, there's no need to check these statically with Eslint, because once we start logging deprecation warnings we'll need to adhere in runtime. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…ress#64591) * Add 40px size lint rule for Block Editor typography components * Exclude all test and story files --------- Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Adds lint rules for
__next40pxDefaultSizeprop adherence on the following@wordpress/block-editorcomponents:Testing Instructions
The lint error should trigger for violations as expected.