Remove GB i18n domain from block-library. #64701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
ramonjd
approved these changes
Aug 22, 2024
gziolo
pushed a commit
that referenced
this pull request
Aug 23, 2024
#64701). As these files are distributed to WordPress in an unaltered form, the domain needs to be removed to allow it to be added to the WordPress translations. Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: ramonjd <[email protected]>
peterwilsoncc
added a commit
to peterwilsoncc/wordpress-develop
that referenced
this pull request
Aug 23, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
WordPress#64701). As these files are distributed to WordPress in an unaltered form, the domain needs to be removed to allow it to be added to the WordPress translations. Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
gutenbergi18n domain from several block library strings.It would be good if this could be included in the 19.1 version of Gutenberg to allow the test package update in WordPress-Develop to proceed cc @artemiomorales
Why?
As these files are distributed to WordPress in an unaltered form, the domain needs to be removed to be added to the WordPress translations.
How?
__\(.*, 'gutenberg'in the packages directoryTesting Instructions
Check strings display as expected in the modified blocks:
Testing Instructions for Keyboard
N/A
Screenshots or screencast