SelectControl: Fix remaining 40px size violations #64831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
mirka
commented
Aug 27, 2024
| @@ -236,8 +236,7 @@ const DimensionControls = ( { | |||
| panelId={ clientId } | |||
| > | |||
| <SelectControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -27,8 +27,7 @@ export default function WidgetTypeSelector( { selectedId, onSelect } ) { | |||
|
|
|||
| return ( | |||
| <SelectControl | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Activate a legacy theme like Twenty Twelve. Go to Appearance ▸ Widgets, and insert a Legacy Widget block.
| Before | After |
|---|---|
 |
 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 27, 2024
Good question. There were a lot more TODO'ed violations when I first added the lint rule, but by now it had already whittled down to two remaining violations! Mostly because I was working on upsizing other components, and if there was a SelectControl in the same screen as those I would upsize it at the same time. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Fix in Featured Image block * Fix in Legacy Widget block * Move lint rule Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Fixes the remaining 40px size violations for SelectControl.
Testing Instructions
See inline comments.