Post Editor: omit meta boxes on “design” type posts #64990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
Size Change: -8 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
stokesman
commented
Sep 2, 2024
| @@ -209,21 +209,19 @@ function Layout( { | |||
| showIconLabels: get( 'core', 'showIconLabels' ), | |||
| isDistractionFree: get( 'core', 'distractionFree' ), | |||
| showMetaBoxes: | |||
| ! DESIGN_POST_TYPES.includes( currentPostType ) && | |||
There was a problem hiding this comment.
This and the change at L351 are the effectual changes, the rest are merely due to refactoring for reuse of the return value from useNavigateToEntityRecord instead of selecting the current post type again from the editor store.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @smerriman, @ericdye, @laurelfulford. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
noisysocks
added
the
Backport to WP 6.7 Beta/RC
t-hamano
approved these changes
Sep 27, 2024
|
Thanks for the review and testing Aki! |
stokesman
force-pushed
the
fix/patterns-keep-post-meta-boxes
branch
from
432ce19 to
6ee4b7b
Compare
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 29, 2024
Unlinked contributors: smerriman, ericdye, laurelfulford. Co-authored-by: t-hamano <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: lgladdy <[email protected]> Co-authored-by: MadtownLems <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 9e14c39 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Unlinked contributors: smerriman, ericdye, laurelfulford. Co-authored-by: t-hamano <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: lgladdy <[email protected]> Co-authored-by: MadtownLems <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit fe5a931.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A fix to avoid a post’s Meta Boxes from showing up when the editor switches to edit other entities like synced patterns.
Why?
A post’s Meta Boxes should not appear to be associated with other entities. This was made to fix #64914 yet also should resolve #63143.
How?
Adds a condition that the post type is not one of the design types ('wp_template', 'wp_template_part', 'wp_block', 'wp_navigation') to the logic for rendering the Meta Boxes.
Testing Instructions
The linked issue is specifically about editing a synced pattern from a post but the same applies for similar scenarios. These instructions cover all relevant ones I can think of.
Testing Instructions for Keyboard
Screenshots or screencast