Add Zoom Out toggle to editor header when experiment enabled #65183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +466 B (+0.03%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Do we want to show this toggle in all editors or just the Site Editor? If it's the later then we'll probably want to use the Slot/Fills to add the Button. |
getdave
commented
Sep 10, 2024
Comment on lines
+150
to
154
| { zoomOutExperimentEnabled && <ZoomOutToggle /> } | ||
|
|
||
| { ( isWideViewport || ! showIconLabels ) && ( | ||
| <PinnedItems.Slot scope="core" /> | ||
| ) } |
There was a problem hiding this comment.
This will currently appear across all editors.
If instead we only want it on the Site Editor then we can use the <PinnedItems.Slot scope="core" /> to add the Toggle.
There was a problem hiding this comment.
I think this is fine for now, it's still behind the flag.
|
We should also remove the zoom out control from the device preview. |
scruffian
previously approved these changes
Sep 10, 2024
getdave
dismissed
scruffian’s stale review
There is a technical implementation that needs fixing first
|
I'd like to use the slots approach before we land this. |
All. :) |
|
@scruffian If @richtabor wants this in all editors then we can probably land it "as is". Feel free to reinstate your ✅ |
|
This button doesn't seem to work if the editor is not an iframe:
|
|
That's strange. It was working for me. I'll look into that. |
@t-hamano Can you share production steps please? 🙏 |
|
@getdave The easiest step is to enable custom fields, but that might be an issue we already had when the zoom out mode toggle was in a dropdown. 54a730c1ed6c065b2b16ee7fa02421cf.mp4 |
|
Ah that's why I didn't notice it. So it looks like "Zoom Out" will need to detect the iframe. Thanks for flagging. |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a Zoom Out toggle button to the editor header area when the relevant experiment is active.
Closes #65162
Why?
See #65162.
How?
squareicon to@wordpress/icons- note I"m happy to pull this into a separate PR if that's preferable.Note that I have not touched the Device Preview dropdown. If we want to remove that
50%behaviour we can do so.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast