Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label enforcer: add Gutenberg plugin to the list of single required labels #65253

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

priethor
Copy link
Contributor

What?

Allows merging PRs that only have Gutenberg plugin label.

Why?

There are meta PRs that shouldn't need any extra label, like #65252

How?

By adding the label to the list of required labels in the label enforcer auatomation

Testing Instructions

  1. Open a non-draft PR
  2. Add the Gutenberg plugin label, and check that the PR can now passes the required label checks

@priethor priethor added [Type] Project Management Meta-issues related to project management of Gutenberg GitHub Actions Pull requests that update GitHub Actions code labels Sep 11, 2024
@priethor priethor requested a review from vcanales September 11, 2024 20:04
@priethor priethor changed the title Label enforcer: add Gutenberg plugin to the list of type labels Label enforcer: add Gutenberg plugin to the list of single required labels Sep 11, 2024
@priethor priethor marked this pull request as ready for review September 11, 2024 20:05
@priethor priethor requested a review from desrosj as a code owner September 11, 2024 20:05
Copy link

github-actions bot commented Sep 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: priethor <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: vcanales <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@priethor priethor requested a review from Mamaduka September 11, 2024 20:05
@vcanales
Copy link
Member

Another option might be to enforce labels only on PRs that target trunk#65252 targets a Release branch.

@vcanales
Copy link
Member

Another option might be to enforce labels only on PRs that target trunk#65252 targets a Release branch.

I'll go ahead and merge this, we can iterate over my suggestion later if necessary.

@vcanales vcanales merged commit 67e7275 into trunk Sep 24, 2024
61 checks passed
@vcanales vcanales deleted the add-gutenberg-plugin-label-as-enough branch September 24, 2024 13:06
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants