DimensionsPanel: Apply 40px default size to UI when no spacing preset is available #65300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.08 kB (+0.06%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 13, 2024
t-hamano
force-pushed
the
dimensions-panel-unify
branch
from
5c129ce to
7f5e6b2
Compare
This was referenced Sep 19, 2024
Bump the wp-packages group across 1 directory with 18 updates
GoogleForCreators/web-stories-wp#13779
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed that the Margin, Padding, Block Spacing UI is not 40px sized when the preset is not present:
Why?
Part of #46734
Testing Instructions
Activate the block theme with the following theme.json applied:
{ "version": 3, "settings": { "appearanceTools": true, "layout": { "contentSize": "840px", "wideSize": "1100px" }, "spacing": { "spacingSizes": [], "defaultSpacingSizes": false } } }