GH Actions/gradle wrapper validation: fix deprecation in workflow #65358
Conversation
The deprecation notice can be seen in any action run summary for this workflow. Ref: https://github.com/gradle/actions/blob/main/docs/deprecation-upgrade-guide.md#the-action-gradlewrapper-validation-action-has-been-replaced-by-gradleactionswrapper-validation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jrfnl
added
the
[Type] Automated Testing
There was a problem hiding this comment.
One small change. Could we use the commit SHA for the action instead of vX? This is recommended for hardening in the GHA security guide. and we follow this practice everywhere else.
It's a bit annoying to have to apply an update every time there's a release, but Dependabot handles that for us so it just requires a review.
Co-authored-by: Jonathan Desrosiers <[email protected]>
|
Apologies! I had totally forgotten about this PR. 😞 This was fixed in #66602 along with an |
|
Oh well... at least it's fixed now. |
What?
The deprecation notice can be seen in any action run summary for this workflow.
Ref: https://github.com/gradle/actions/blob/main/docs/deprecation-upgrade-guide.md#the-action-gradlewrapper-validation-action-has-been-replaced-by-gradleactionswrapper-validation